-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1176 - Migrate from other chains #1178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together! Not an easy document to write, so it needs a bit more polishing.
I have submitted a thorough editing pass with PR #1183. Please take a look at this first. After reviewing my updates, please rename the file to moving-to-casper.md to remove any ambiguity with the word “migrate”.
In addition, I have a few more requests.
Please try to remove repeated explanations in the five categories you defined (lifecycle, storage, methods etc.). For example, we are referencing Named Keys and Dictionaries three times. Resources are defined twice.
State management can be combined with storage, actually. If you want to keep them separate, try to find another way to organize the content so there is less duplication.
I would like to see more links to coding examples. There are some, but many sections seem theoretical. You could link to any relevant topics (either in the Casper docs or externally).
For example, when explaining get_key, at a minimum, link to docs.rs. Also, point to the reading-and-writing-to-the-blockchain.md file.
This request applies to all concepts and explanations introduced.
Finally, a little more structure would be needed. For example, what are the comparison points in each tab? Are they covered for each blockchain?
Please also check the Casper docs style guidelines before submitting a PR. It's not in this PR's checklist, but it's not optional.
Co-authored-by: Adam Stone <[email protected]>
Co-authored-by: Adam Stone <[email protected]>
Co-authored-by: Adam Stone <[email protected]>
Editing pass for PR 1178
@KMCreatesWorlds @andrzej-casper Acknowledging the review request. |
@KMCreatesWorlds, please address or respond to my requests from the previous review feedback. The document still needs some polishing. Summarizing my previous feedback here:
cc @andrzej-casper @melpadden |
@KMCreatesWorlds could you take a look at @ipopescu review feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @KMCreatesWorlds.
Here are a few minor edit requests. From the previous feedback, I see the following have been addressed - thanks!
- Renamed file to moving-to-casper.md
- Combined state management with storage
- Removed repeated definitions (Resouces, Named Keys, Dictionaries)
Let's discuss the following on the live call:
- Cross-links to each topic in the Casper docs or link out to coding examples
- Tab structure. What are the comparison points in each tab? Are they covered for each blockchain?
cc @ACStoneCL
config/sidebar.config.js
Outdated
@@ -281,6 +281,7 @@ module.exports = { | |||
"resources/build-on-casper", | |||
"resources/casper-open-source-software", | |||
"resources/quick-start", | |||
"resources/moving-to-casper", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move this higher, perhaps after build-on-casper
.
Also, the table on the resouces/index.md page needs to be updated with this topic (the table matches the left nav order).
Karol and I spoke and we are on the same page. We have cross-links for Casper, but we won't add links on the other tabs. Developers coming from other protocols should already be familiar with them. |
Co-authored-by: Iulia Popescu <[email protected]>
Co-authored-by: Iulia Popescu <[email protected]>
Co-authored-by: Iulia Popescu <[email protected]>
Co-authored-by: Iulia Popescu <[email protected]>
Co-authored-by: Iulia Popescu <[email protected]>
Co-authored-by: Iulia Popescu <[email protected]>
Co-authored-by: Iulia Popescu <[email protected]>
Co-authored-by: Iulia Popescu <[email protected]>
Co-authored-by: Iulia Popescu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this locally and it looks great. Thank you, @KMCreatesWorlds!
What does this PR fix/introduce?
This PR introduces the overview of how the move from some blockchains can be made to Casper.
Additional context
The PR gives insight into Ethereum, Near, Solana, and Aptos and how they compare to Casper regarding aspects such as Contract Lifecycle, State Management, or how to interact with the Contract.
This is not a comprehensive explanation of how the migration of a Contract for example on Ethereum can be made on Casper, but instead gives high-level hints on how to approach the individual aspects to make the move to Casper easier.
Checklist
yarn install && yarn run build
.../../faq/faq-general.md
- instead of introducing absolute file path, or relative/absolute URL.yarn run check:externals
.Reviewers
@caspermel